fix value of fn-fdk-version to include the fdk language#99
Merged
Conversation
Collaborator
Author
|
Note that due to pytest breaking today pytest-dev/pytest#5901 I had to pin a dependency to a specific version to get the tests to pass |
rdallman
approved these changes
Oct 2, 2019
Member
|
Release script didn't work, deploy keys didn't work again. cc @rdallman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of the Fn-Fdk-Version header does not include the fdk language as specified in the docs: https://github.com/fnproject/docs/pull/70/files
This PR fixes the value of the header to match the specification "fdk-python/x.y.z" in the docs and the initial issue fnproject/fn#1302