fix: sponsor form description/instructions validation for html#775
Merged
fix: sponsor form description/instructions validation for html#775
Conversation
📝 WalkthroughWalkthroughAdd an HTML-normalizing validator and replace plain-string required validations with an HTML-aware validator across rich-text inputs and several form validation schemas; introduce normalizeHtmlString and wire it into the editor and yup utilities. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip We've launched Issue Planner and it is currently in beta. Please try it out and share your feedback on Discord! Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/utils/yup.js`:
- Around line 90-104: The transform in requiredHTMLValidation currently strips
tags but leaves HTML entities like so strings like "<p> </p>" pass
validation; update the normalization to convert non-breaking spaces to regular
spaces before trimming—either modify stripHtmlTags or the transform in
requiredHTMLValidation to replace occurrences of " " and " " (or
convert \u00A0) with a normal space, then strip tags and call .trim(); ensure
you reference stripHtmlTags and requiredHTMLValidation so the transform returns
a truly empty string for content that only contains NBSPs.
smarcet
reviewed
Feb 4, 2026
src/utils/yup.js
Outdated
| .transform((value, originalValue) => { | ||
| // If the value is a string, strip HTML tags | ||
| if (typeof originalValue === "string") { | ||
| const strippedValue = stripHtmlTags(originalValue); |
There was a problem hiding this comment.
@santipalenque can we use this helper method here https://github.com/fntechgit/summit-admin/blob/cd303a70610bfda34d21ed868870aa3a1edc7e59/src/components/inputs/utils/normalizeJoditEmpty.js ? instead of stripHtmlTags?
smarcet
requested changes
Feb 4, 2026
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@santipalenque please review comments
santipalenque
force-pushed
the
fix/sponsor-form-desc-validation
branch
from
97b2bdc to
5e468d2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/utils/yup.js`:
- Around line 90-105: The transform in requiredHTMLValidation currently strips
tags but leaves HTML entities like so strings of entities can pass
validation; update either stripHtmlTags or the transform callback in
requiredHTMLValidation to first normalize HTML entities to regular whitespace
(e.g., replace common entities such as and numeric entities like  
or use a generic regex /&[^\s;]+;/g → ' ') before stripping tags and trimming,
ensuring entity-only content becomes empty and fails the required check.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/utils/normalize-html-string/index.js`:
- Around line 1-4: normalizeHtmlString currently checks
doc.body.textContent.length === 0 which treats whitespace and non-breaking
spaces as content; update the check to normalize whitespace by trimming and
replacing NBSPs (e.g., replace \u00A0 with regular space) and collapsing
whitespace before measuring length. Specifically, in normalizeHtmlString use new
DOMParser().parseFromString(textInput, "text/html") to get doc, compute a
normalizedText from doc.body.textContent by replacing \u00A0 with ' ',
collapsing consecutive whitespace to a single space and trimming, then return ""
if normalizedText.length === 0 otherwise return textInput.
Comment on lines
1
to
4
| // removes html tags if contained text is empty | ||
| const normalizeHtmlString = (textInput) => { | ||
| const doc = new DOMParser().parseFromString(textInput, "text/html"); | ||
| return doc.body.textContent.length === 0 ? "" : textInput; |
There was a problem hiding this comment.
Treat whitespace-only HTML as empty.
textContent.length === 0 will treat whitespace or as content, so required HTML validation can pass with visually empty input. Normalize whitespace before checking length.
🛠️ Proposed fix
- return doc.body.textContent.length === 0 ? "" : textInput;
+ const text = doc.body.textContent.replace(/\u00a0/g, " ").trim();
+ return text.length === 0 ? "" : textInput;🤖 Prompt for AI Agents
In `@src/utils/normalize-html-string/index.js` around lines 1 - 4,
normalizeHtmlString currently checks doc.body.textContent.length === 0 which
treats whitespace and non-breaking spaces as content; update the check to
normalize whitespace by trimming and replacing NBSPs (e.g., replace \u00A0 with
regular space) and collapsing whitespace before measuring length. Specifically,
in normalizeHtmlString use new DOMParser().parseFromString(textInput,
"text/html") to get doc, compute a normalizedText from doc.body.textContent by
replacing \u00A0 with ' ', collapsing consecutive whitespace to a single space
and trimming, then return "" if normalizedText.length === 0 otherwise return
textInput.
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86b8b1nup
Summary by CodeRabbit