fix: update additional input list from uicore, update uicore version,…

[tomrndom]

… clean unused components

ref: https://app.clickup.com/t/86b8t9k79

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

• Chores
  • Upgraded React and related packages to React 17 and bumped core UI library to v5.
  • Switched meta-field / additional-input UI to use the shared UI library instead of local implementations.
• Localization
  • Updated English strings for meta-field / additional-input labels, placeholders, and value-management text.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af6e714b-4e1e-48fe-9f6f-24b8177e3971

📥 Commits

Reviewing files that changed from the base of the PR and between 7a857e6 and 1eec7cd.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (1)

• package.json

🚧 Files skipped from review as they are similar to previous changes (1)

• package.json

---

📝 Walkthrough

Walkthrough

This PR upgrades openstack-uicore-foundation to v5.0.1, removes several local meta-field/additional-input components and their tests, updates i18n keys for meta-fields/additional inputs, and replaces local imports with the external package's AdditionalInputList.

Changes

Cohort / File(s)	Summary
Dependency package.json	Bumped openstack-uicore-foundation from 4.2.23 → 5.0.1, and upgraded react/react-dom to ^17.0.0.
Removed local meta-field components src/components/forms/form-template-meta-field-form.js, src/components/forms/inventory-item-meta-field-form.js, src/components/mui/formik-inputs/additional-input/additional-input-list.js, src/components/mui/formik-inputs/additional-input/additional-input.js, src/components/mui/formik-inputs/additional-input/meta-field-values.js	Deleted local implementations of additional-input/meta-field components (state management, Formik bindings, add/remove, value editing, DnD ordering, confirmation flows).
Deleted tests src/components/mui/__tests__/additional-input-list.test.js, src/components/mui/__tests__/additional-input.test.js, src/components/mui/__tests__/meta-field-values.test.js	Removed unit tests covering rendering, interactions, validation, and deletion behavior for the deleted components.
Import updates (use external component) src/pages/sponsors-global/form-templates/form-template-popup.js, src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js, src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js, src/pages/sponsors/sponsor-forms-list-page/components/form-template/form-template-form.js, src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/components/customized-form/customized-form.js	Repointed imports to openstack-uicore-foundation/lib/components/mui/formik-inputs/additional-input-list instead of local relative paths; usage/props unchanged.
i18n changes src/i18n/en.json	Restructured localization: removed scattered meta_field_* keys, added additional_inputs and meta_fields objects with renamed placeholders and warnings to match external component keys.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• feat: use formik on additional input list, unify use #744: Touches the same AdditionalInput/MetaField components but previously added local Formik implementations — likely inverse to this PR.
• fix: update uicore version, adjust query functions to unify urijs use #749: Also modifies openstack-uicore-foundation dependency/versioning; related at dependency/import level.
• fix: refactor sponsor page routes #859: Adjusts sponsor-page imports and paths that overlap with this PR's import updates.

Suggested reviewers

• smarcet

Poem

🐰 Hooray, the components hop away,

Imports point to fields that play,
Keys rearranged to match their tune,
Local code waves at the new moon,
A carrot cheer for tidy rooms! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main changes: updating the additional input list component from uicore, bumping the uicore version, and cleaning up unused components. It is concise and clearly summarizes the primary objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/additional-input-list-uicore

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 93: Your bump of the dependency openstack-uicore-foundation to 5.0.1
introduces a React peerDependency mismatch because this repository's react and
react-dom are pinned to 16.13.1; either revert openstack-uicore-foundation back
to a 4.2.x release or upgrade react and react-dom to a 17.x release to satisfy
^17.0.0. Locate the package.json entry for "openstack-uicore-foundation" and
either change its version back to a 4.2.x tag or change the "react" and
"react-dom" entries from 16.13.1 to a compatible 17.x version, then regenerate
your lockfile (npm/yarn/pnpm) and run the test/build suite to validate the
change. Ensure the chosen approach is reflected in any CI config and document
the decision in the PR description.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b29ad360-ca26-4d73-8106-02ece7eaf161

📥 Commits

Reviewing files that changed from the base of the PR and between 033cf84 and 7a857e6.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (15)

• package.json
• src/components/forms/form-template-meta-field-form.js
• src/components/forms/inventory-item-meta-field-form.js
• src/components/mui/__tests__/additional-input-list.test.js
• src/components/mui/__tests__/additional-input.test.js
• src/components/mui/__tests__/meta-field-values.test.js
• src/components/mui/formik-inputs/additional-input/additional-input-list.js
• src/components/mui/formik-inputs/additional-input/additional-input.js
• src/components/mui/formik-inputs/additional-input/meta-field-values.js
• src/i18n/en.json
• src/pages/sponsors-global/form-templates/form-template-popup.js
• src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js
• src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js
• src/pages/sponsors/sponsor-forms-list-page/components/form-template/form-template-form.js
• src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/components/customized-form/customized-form.js

💤 Files with no reviewable changes (8)

• src/components/mui/tests/additional-input.test.js
• src/components/forms/form-template-meta-field-form.js
• src/components/mui/tests/additional-input-list.test.js
• src/components/mui/tests/meta-field-values.test.js
• src/components/mui/formik-inputs/additional-input/additional-input.js
• src/components/forms/inventory-item-meta-field-form.js
• src/components/mui/formik-inputs/additional-input/meta-field-values.js
• src/components/mui/formik-inputs/additional-input/additional-input-list.js