Skip to content

fix: add sponsor to dependency array on forms and pages tabs #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarcet merged 3 commits into from
Apr 28, 2026
+17 −9
Merged

fix: add sponsor to dependency array on forms and pages tabs #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0df353
fix: add sponsor to dependency array on sponsor forms and pages tabs
tomrndom Apr 16, 2026
5c60cb4
fix: add sponsor id on media upload dependency array useEffect
tomrndom Apr 16, 2026
b27e964
fix: add sponsor on dependency array for puchases tab
tomrndom Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const SponsorFormsTab = ({
useEffect(() => {
getSponsorManagedForms();
getSponsorCustomizedForms();
}, []);
}, [sponsor?.id]);

const handleManagedPageChange = (page) => {
const { perPage, order, orderDir } = managedForms;
Expand Down Expand Up @@ -157,7 +157,8 @@ const SponsorFormsTab = ({
);
};

const handleSaveFormFromTemplate = (entity) => saveSponsorManagedForm(entity).then(() => {
const handleSaveFormFromTemplate = (entity) =>
saveSponsorManagedForm(entity).then(() => {
const { perPage, order, orderDir } = managedForms;
getSponsorManagedForms(
term,
Expand Down
8 changes: 5 additions & 3 deletions src/pages/sponsors/sponsor-page/tabs/sponsor-media-upload-tab/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import UploadDialog from "../../../../../components/upload-dialog";
import showConfirmDialog from "../../../../../components/mui/showConfirmDialog";

const SponsorMediaUploadTab = ({
sponsor,
sponsorRequests,
generalRequests,
getSponsorMURequests,
Expand All @@ -44,7 +45,7 @@ const SponsorMediaUploadTab = ({
useEffect(() => {
getSponsorMURequests();
getGeneralMURequests();
}, []);
}, [sponsor?.id]);

const handleSponsorPageChange = (page) => {
const { perPage, order, orderDir } = sponsorRequests;
Expand Down Expand Up @@ -271,8 +272,9 @@ const SponsorMediaUploadTab = ({
);
};

const mapStateToProps = ({ sponsorPageMUListState }) => ({
...sponsorPageMUListState
const mapStateToProps = ({ sponsorPageMUListState, currentSponsorState }) => ({
...sponsorPageMUListState,
sponsor: currentSponsorState.entity
});

export default connect(mapStateToProps, {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const SponsorPagesTab = ({
useEffect(() => {
getSponsorManagedPages();
getSponsorCustomizedPages();
}, []);
}, [sponsor?.id]);

const handleManagedPageChange = (page) => {
const { perPage, order, orderDir } = managedPages;
Expand Down
11 changes: 8 additions & 3 deletions src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
} from "../../../../../utils/constants";

const SponsorPurchasesTab = ({
sponsor,
purchases,
term,
order,
Expand All @@ -43,7 +44,7 @@ const SponsorPurchasesTab = ({
}) => {
useEffect(() => {
getSponsorPurchases();
}, []);
}, [sponsor?.id]);

const handlePageChange = (page) => {
getSponsorPurchases(term, page, perPage, order, orderDir);
Expand Down Expand Up @@ -195,8 +196,12 @@ const SponsorPurchasesTab = ({
);
};

const mapStateToProps = ({ sponsorPagePurchaseListState }) => ({
...sponsorPagePurchaseListState
const mapStateToProps = ({
sponsorPagePurchaseListState,
currentSponsorState
}) => ({
...sponsorPagePurchaseListState,
sponsor: currentSponsorState.entity
});

export default connect(mapStateToProps, {
Expand Down
Loading