Skip to content

fix: ticket type UI improvements#138

Merged
gcutrini merged 1 commit into
mainfrom
fix/ticket-type-ui
Feb 24, 2026
Merged

fix: ticket type UI improvements#138
gcutrini merged 1 commit into
mainfrom
fix/ticket-type-ui

Conversation

@gcutrini
Copy link
Copy Markdown
Member

@gcutrini gcutrini commented Feb 5, 2026

This PR fixes:

  • Invisible plus (+) button on ticket quantity controls
  • Quantity controls being pushed off-screen on narrow viewports
  • Selected ticket text being overly truncated in the dropdown
  • Add Bootstrap 3 CSS to dev page to match production environment

ref: https://app.clickup.com/t/86b8e4r1b

Summary by CodeRabbit

  • Documentation

    • Added a "Required external stylesheets" note listing Bootstrap 3 and Font Awesome 4 as required before mounting the widget.
  • Style

    • Improved ticket dropdown layout to use flexible sizing for better fit in responsive containers.
    • Updated the add-ticket button icon.
    • Included Bootstrap stylesheet support for consistent styling.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 5, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b3b75e and 6f2dfd4.

📒 Files selected for processing (5)
  • README.md
  • src/components/ticket-dropdown/index.module.scss
  • src/components/ticket-type/index.js
  • src/components/ticket-type/index.module.scss
  • src/index.ejs

📝 Walkthrough

Walkthrough

Added external stylesheet docs and a Bootstrap CDN link; migrated one UI icon from glyphicon to Font Awesome; and adjusted SCSS to prefer flex sizing and min-width tweaks for dropdown and ticket elements. No control-flow or logic changes.

Changes

Cohort / File(s) Summary
Documentation
README.md
Added "Required external stylesheets" section listing Bootstrap 3 and Font Awesome 4 CDN URLs required before mounting the widget.
CDN Integration
src/index.ejs
Inserted Bootstrap 3.3.7 CSS CDN link into the HTML template (stylesheet only; no structural changes).
Icon update
src/components/ticket-type/index.js
Replaced glyphicon-plus with fa-plus for the add-ticket button (icon class swap only).
Flex / layout tweaks
src/components/ticket-dropdown/index.module.scss, src/components/ticket-type/index.module.scss
Changed sizing to flex-friendly rules: added flex: 1/min-width: 0, removed prior max-width/max-height/word-wrap limits and responsive breakpoints to allow proper shrinking/truncation within flex containers.

Sequence Diagram(s)

(omitted — changes are documentation/UI styling and a simple icon swap; no multi-component control-flow to visualize)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • santipalenque

Poem

🐰 From glyphicons old to Font Awesome bright,
Flex grows gentle, shrinking done just right.
Bootstrap sails in on CDN seas,
Read the README, load styles with ease —
A hopping widget, tidy and light. 🎩

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: ticket type UI improvements' is directly related to the main changes: fixing the invisible plus button, preventing quantity controls from being pushed off-screen, and improving dropdown text display—all UI improvements to the ticket type component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ticket-type-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@santipalenque santipalenque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Replace glyphicon-plus with fa-plus for the increment button
  (Glyphicons font is not loaded, FontAwesome is)
- Add min-width: 0 on ticket dropdown to prevent quantity controls
  from being pushed off-screen
- Make selected ticket text fill available space instead of using
  fixed max-width breakpoints
- Add Bootstrap 3 CSS to dev page to match production environment
- Document required external stylesheets in README
@gcutrini gcutrini merged commit 6030fc3 into main Feb 24, 2026
1 check was pending
@gcutrini gcutrini deleted the fix/ticket-type-ui branch February 24, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants