fix autoscaling activities collection setup #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah that does look weird before and better now. Thanks! |
geemus
added a commit
that referenced
this pull request
Jan 26, 2015
fix autoscaling activities collection setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AutoScaling#Group.activities method was doing something very strange - loading the collection rather than letting it load itself.
The activities model itself was also doing something very strange since it was assuming that all the arguments passed to it were filters, whereas we need to pass in the service (and since filters are dumped straight into the request parameters this caused an exception in the request signing code).
I'm not super familiar with the Fog::Collection stuff, but I think this is closer to what it should do (and does actually work).