Fix insert_server.rb scheduling option#304
Merged
icco merged 1 commit intofog:masterfrom Feb 14, 2018
KohlsTechnology:insert-server-fix-scheduling
Merged
Fix insert_server.rb scheduling option#304icco merged 1 commit intofog:masterfrom KohlsTechnology:insert-server-fix-scheduling
icco merged 1 commit intofog:masterfrom
KohlsTechnology:insert-server-fix-scheduling
Conversation
Contributor
Author
|
It looks lijke I have not tested this yet, but it looks like it should be a simple change. I'll try to test this tomorrow. |
Contributor
Author
|
I was able to test this code and it is working. Let me know if any changes are needed on this PR. |
seanmalloy
changed the title
The conditional statement for the scheduling option was calling the wrong class, Google::Apis::ComputeV1::ServiceAccount. Class Google::Apis::ComputeV1::Scheduling should be called instead. This pull request fixes this issue.
icco
approved these changes
Feb 14, 2018
Member
|
Makes sense, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.