Replace deprecated MultiJson.encode/decode with dump/load#24
Merged
geemus merged 1 commit intoApr 21, 2026
Merged
Conversation
MultiJson.encode and MultiJson.decode are deprecated aliases and scheduled for removal in MultiJson 2.0. Call the canonical MultiJson.dump and MultiJson.load methods so downstream users do not see deprecation warnings (which can escalate to errors when Ruby's warning handler is configured to raise, e.g. via Bugsnag).
Member
|
Just reactivated CI (it had stopped due to inactivity). Going to close/reopen this PR to hopefully trigger that. |
Member
|
Trying again (did broader fixes to the tests/CI setup). |
Member
|
@mikevoets Thanks for the fix! |
Member
|
released in v1.6.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MultiJson.encodeandMultiJson.decodeare deprecated aliases and are slated for removal in MultiJson 2.0. Each call emits a deprecation warning viaKernel#warn:This PR swaps the internal calls to the canonical
MultiJson.dump/MultiJson.loadmethods. Behavior is unchanged:dump/loadare the real implementations thatencode/decodealias to.