Skip to content

Bluemix object storage fixes#1

Closed
gekola wants to merge 1 commit intofog:masterfrom
gekola:fix-bluemix
Closed

Bluemix object storage fixes#1
gekola wants to merge 1 commit intofog:masterfrom
gekola:fix-bluemix

Conversation

@gekola
Copy link
Copy Markdown
Contributor

@gekola gekola commented Feb 23, 2016

  • Fix 500 due to port presence in Host header for bluemix object storage
  • Recognize userid as argument

 * Fix 500 due to port in Host header for bluemix object storage
 * Recognize userid as argument
@seanhandley
Copy link
Copy Markdown
Member

Not sure I'm comfortable with the change that omits the default port (though including the userid is obviously a good idea).

A lot of different systems use the Fog OpenStack implementation and changing things in the headers we send could lead to unpredictable breakages in other people's integrations.

Can you describe in some more detail how IBM BlueMix is breaking when used with Fog @gekola?

@Ladas
Copy link
Copy Markdown
Contributor

Ladas commented Mar 1, 2016

I've been meaning to tests this, but our keystone v3 integration tests are down due to caching issues, so it might take some time.

But I agree, feels dangerous to change header like this. If should be configurable, so passing e.g. options[:openstack_omit_default_port] and adding it to header only if that config is true

@gekola
Copy link
Copy Markdown
Contributor Author

gekola commented Mar 1, 2016

The problem with IBM Bluemix Object Storage is when authorizing with auth_url being https://lon-identity.open.softlayer.com/v3/auth/tokens (or https://identity.open.softlayer.com/v3/auth/tokens) when Host header contain port (443) the server always returns 500 without further problem explanation.

I agree making the omission optional is a safer way to go. I'll update the PR.

@gekola gekola closed this Mar 2, 2016
ares pushed a commit that referenced this pull request Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants