Conversation
gekola
commented
Feb 23, 2016
- Fix 500 due to port presence in Host header for bluemix object storage
- Recognize userid as argument
* Fix 500 due to port in Host header for bluemix object storage * Recognize userid as argument
|
Not sure I'm comfortable with the change that omits the default port (though including the userid is obviously a good idea). A lot of different systems use the Fog OpenStack implementation and changing things in the headers we send could lead to unpredictable breakages in other people's integrations. Can you describe in some more detail how IBM BlueMix is breaking when used with Fog @gekola? |
|
I've been meaning to tests this, but our keystone v3 integration tests are down due to caching issues, so it might take some time. But I agree, feels dangerous to change header like this. If should be configurable, so passing e.g. options[:openstack_omit_default_port] and adding it to header only if that config is true |
|
The problem with IBM Bluemix Object Storage is when authorizing with I agree making the omission optional is a safer way to go. I'll update the PR. |