Shindo to Minitest: common4#135
Merged
gildub merged 1 commit intofog:masterfrom May 25, 2016
gildub:shindo_to_minitest-common4
Merged
Shindo to Minitest: common4#135gildub merged 1 commit intofog:masterfrom gildub:shindo_to_minitest-common4
gildub merged 1 commit intofog:masterfrom
gildub:shindo_to_minitest-common4
Conversation
test/test_helper.rb
Outdated
| module Minitest | ||
| class Test | ||
| # Some tests need to be fixed. There are skipped unless the following is true | ||
| UNIT_TESTS_CLEAN = false.freeze |
There was a problem hiding this comment.
Freezing immutable objects is pointless.
test/helpers/collection_helper.rb
Outdated
|
|
||
| # JRuby 1.7.5+ issue causes a SystemStackError: stack level too deep | ||
| # https://github.com/jruby/jruby/issues/1265 | ||
| if RUBY_PLATFORM == "java" and JRUBY_VERSION =~ /1\.7\.[5-8]/ |
|
Changes Unknown when pulling 4be03bf on gildub:shindo_to_minitest-common4 into * on fog:master*. |
test/helpers/collection_helper.rb
Outdated
| if collection.respond_to?(enum_method) | ||
| it "##{enum_method}" do | ||
| block_called = false | ||
| collection.send(enum_method) { block_called = true; 0 } |
There was a problem hiding this comment.
Do not use semicolons to terminate expressions.
|
Changes Unknown when pulling 406d597 on gildub:shindo_to_minitest-common4 into * on fog:master*. |
Adds a migrated version of collection_helper.rb & model_helper.rb helpers to Minitest in /test/helpers Also, adds a UNIT_TESTS_CLEAN flag to skip broken test
Collaborator
Author
|
This is the fourth part for the common base needed for the incoming "Shindo to Minitest" sequel. |
|
Changes Unknown when pulling eb64cc0 on gildub:shindo_to_minitest-common4 into * on fog:master*. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a migrated version of collection_helper.rb & model_helper.rb
helpers to Minitest in /test/helpers
Also, adds a UNIT_TESTS_CLEAN flag to skip broken test