[openstack] storage does not require api_key and username#3816
Merged
geemus merged 1 commit intofog:masterfrom Jan 6, 2016
Carthaca:openstack_storage_not_required_arguments
Merged
[openstack] storage does not require api_key and username#3816geemus merged 1 commit intofog:masterfrom Carthaca:openstack_storage_not_required_arguments
geemus merged 1 commit intofog:masterfrom
Carthaca:openstack_storage_not_required_arguments
Conversation
geemus
added a commit
that referenced
this pull request
Jan 6, 2016
…_arguments [openstack] storage does not require api_key and username
Member
|
Thanks! |
Contributor
Author
|
Thanks for the quick merge. May I ask, why you accept it though the tests are failing? Is it okay in the transition to Ruby version >= 2? |
Member
|
@MaPoCaCe yeah, I checked the tests but they appeared to be unrelated (and a known issue I've been trying to work on). Hopefully that will get fixed soon. We've been trying to avoid getting rid of old rubies since many still use them, but it will inevitably happen eventually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openstack_api_keyandopenstack_usernameare not requiredopenstack_auth_token