Skip to content

Comments

[openstack] storage does not require api_key and username#3816

Merged
geemus merged 1 commit intofog:masterfrom
Carthaca:openstack_storage_not_required_arguments
Jan 6, 2016
Merged

[openstack] storage does not require api_key and username#3816
geemus merged 1 commit intofog:masterfrom
Carthaca:openstack_storage_not_required_arguments

Conversation

@Carthaca
Copy link
Contributor

@Carthaca Carthaca commented Jan 6, 2016

  • same as with all the other services openstack_api_key and openstack_username are not required
  • enables using the openstack_auth_token

geemus added a commit that referenced this pull request Jan 6, 2016
…_arguments

[openstack] storage does not require api_key and username
@geemus geemus merged commit 1ebd858 into fog:master Jan 6, 2016
@geemus
Copy link
Member

geemus commented Jan 6, 2016

Thanks!

@Carthaca
Copy link
Contributor Author

Carthaca commented Jan 7, 2016

Thanks for the quick merge. May I ask, why you accept it though the tests are failing? Is it okay in the transition to Ruby version >= 2?

@geemus
Copy link
Member

geemus commented Jan 7, 2016

@MaPoCaCe yeah, I checked the tests but they appeared to be unrelated (and a known issue I've been trying to work on). Hopefully that will get fixed soon. We've been trying to avoid getting rid of old rubies since many still use them, but it will inevitably happen eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants