Conversation
intent(flag_groups): encode flag type (value vs bool) and value restrictions directly in the definition string, removing the need for `<flag:name>` to consume a trailing value pattern token decision(flag_groups): reuse the existing pattern syntax (pipe-separated aliases + optional value pattern) so users learn one notation for both rules and definitions learned(flag_groups): the old `<flag:name> VALUE_PATTERN` design forced `*` to serve double duty as both value capture and remaining-args wildcard, making patterns like `<flag:name> * *` confusing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…sing intent(flag_groups): eliminate duplicated parsing logic between `parse_flag_group_definition` and the rule pattern parser decision(flag_groups): pass definition strings through the existing `build_pattern_tokens` with `inside_group = true` so that trailing `*` is consumed as a value pattern, then extract aliases and value from the resulting `FlagWithValue` or `Alternation` token Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors flag group definitions from arrays to pattern strings, enabling support for boolean flags and value-restricted matching. The flag:name placeholder is now standalone in rule patterns, as its value-handling behavior is derived from the group's definition. Feedback was provided regarding the performance overhead of parsing these definition strings repeatedly during the matching process, suggesting they be parsed once and cached.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
- Coverage 89.13% 89.05% -0.08%
==========================================
Files 53 53
Lines 11603 11665 +62
==========================================
+ Hits 10342 10388 +46
- Misses 1261 1277 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
intent(flag_groups): avoid redundant parsing of flag group definition strings during pattern matching, which is called repeatedly due to backtracking in the recursive match_engine decision(flag_groups): add a `parsed_flag_groups` field to Definitions populated eagerly after config load/merge/validate, keeping the parse-once-use-many pattern without changing match_engine's signature Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
<flag:name> *in a pattern consumes*as the flag's value pattern, requiring an extra*for remaining-token absorption (<flag:name> * *), which is confusingWhat
flag_groupsdefinition format from arrays to pattern stringsBefore:
After:
<flag:name>no longer consumes the next token as a value pattern, making patterns more intuitive