Add more detailed information about the compressed chunks #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folbricht
reviewed
Oct 30, 2024
Contributor
Author
|
Thanks for the review. By the end of the week I should be able to find some time to address the points raised. |
RyuzakiKK
force-pushed
the
precise_size
branch
2 times, most recently
from
b4e607b to
7acdd94
Compare
folbricht
reviewed
Nov 15, 2024
Owner
folbricht
left a comment
folbricht
left a comment
There was a problem hiding this comment.
It's close, just left some minor comments
Add a new `inspect-chunks` command that can provide additional information about the chunks in an index, including their compressed size (if a local store is provided). One use case is for the clients to download the server's inspect-chunks JSON and feed it into `desync info`, to calculate the precise download size of an update. Signed-off-by: Ludovico de Nittis <ludovico.denittis@collabora.com>
RyuzakiKK
force-pushed
the
precise_size
branch
from
7acdd94 to
ba044f9
Compare
folbricht
approved these changes
Nov 30, 2024
Owner
folbricht
left a comment
folbricht
left a comment
There was a problem hiding this comment.
Thank you. Would it be worth adding an example to the README for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list-chunkshas now a new--detailedoption that allows to print additional information about the chunks, including their compressed size (if a local store is provided).One use case is for the clients to download the server's list-chunks JSON and feed it into
desync info, to calculate the precise download size of an update.Addresses #270