Reject --mutual-tls and --client-ca when TLS is not enabled#330
Merged
Reject --mutual-tls and --client-ca when TLS is not enabled#330
Conversation
Previously --mutual-tls and --client-ca were silently ignored when --cert/--key were not provided, which could lead an operator to believe client certificate authentication was enforcing access while the server was actually listening on plain HTTP. Both chunk-server and index-server now refuse to start in that state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--mutual-tlsand--client-cawere silently ignored bychunk-serverandindex-serverwhen--cert/--keywere not provided, because the TLS config is only consulted onListenAndServeTLS. An operator could believe client-certificate authentication was gating access while the server was actually listening on plain HTTP.Both flags now fail validation at startup in
cmdServerOptions.validate()unless TLS is enabled.