MODEXPW-635 - Add request permissions to retrieve user and contributor name types #380
Open
markusweigelt wants to merge 1 commit into
Open
MODEXPW-635 - Add request permissions to retrieve user and contributor name types #380markusweigelt wants to merge 1 commit into
markusweigelt wants to merge 1 commit into
Conversation
markusweigelt
force-pushed
the
MODEXPW-635
branch
from
20822f9 to
14d73ba
Compare
Grant users.item.get and inventory-storage.contributor-name-types.item.get on the POST /jobs and /jobs/send handlers, the system user, and system-user-permissions.csv, so the worker can resolve createdByUser and contributor name types when building the EDIFACT order-email context.
markusweigelt
force-pushed
the
MODEXPW-635
branch
from
14d73ba to
78321c2
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODEXPW-635 - Add request permissions to retrieve user and contributor name types
Purpose
The order-email template context added in mod-data-export-worker (
OrderEmailContextMapper) makes two new by-id item GETs —GET users/{id}andGET contributor-name-types/{id}- to resolve the order's createdByUser and the contributors' name types. The worker runs the EDIFACT orders export under the token/permissions granted by mod-data-export-spring, which did not permit either call, so both would fail with 403 at runtime.Approach
users.item.getandinventory-storage.contributor-name-types.item.gettodescriptors/ModuleDescriptor-template.json, mirroring the existinginventory-storage.identifier-types.item.getplacement.POST /data-export-spring/jobsandPOST /data-export-spring/jobs/sendhandlermodulePermissions, the visibledata-export.edifact.orders.createpermissionSet, and the system user'suser.permissions.