Skip to content

MDEXP-884: Set export job filename suffix according to output format#579

Merged
zepheiryan merged 7 commits intomasterfrom
MDEXP-884
Nov 20, 2025
Merged

MDEXP-884: Set export job filename suffix according to output format#579
zepheiryan merged 7 commits intomasterfrom
MDEXP-884

Conversation

@zepheiryan
Copy link
Contributor

Purpose

https://folio-org.atlassian.net/browse/MDEXP-884

Support a better user experience by making sure the file suffix is set consistently from the start.

Approach

Base the output file suffix on the mapping profile output format, set when the job execution's filename is first created.

Remove strategy-based suffix setting and instead read the suffix from each actual file, using it in the S3 path or the zip file internal path.

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?

    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • Check logging
    • There are no major code smells or security issues
  • Does this introduce breaking changes?

    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@zepheiryan zepheiryan marked this pull request as ready for review November 7, 2025 23:12
@zepheiryan zepheiryan marked this pull request as draft November 8, 2025 00:12
@zepheiryan zepheiryan marked this pull request as ready for review November 10, 2025 19:19
@zepheiryan
Copy link
Contributor Author

@khandramai After checking in a dev environment, I found the intermediate file from createFileNameWithPlaceHolder would switch the file suffix back to .mrc and that would get used instead in the end. This should be fixed with the latest commit.

@sonarqubecloud
Copy link

@zepheiryan zepheiryan merged commit c088591 into master Nov 20, 2025
4 checks passed
@zepheiryan zepheiryan deleted the MDEXP-884 branch November 20, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants