MDEXP-884: Set export job filename suffix according to output format#579
Merged
zepheiryan merged 7 commits intomasterfrom Nov 20, 2025
Merged
MDEXP-884: Set export job filename suffix according to output format#579zepheiryan merged 7 commits intomasterfrom
zepheiryan merged 7 commits intomasterfrom
Conversation
…ough to S3 upload instead of also using strategy to determine file suffix.
khandramai
reviewed
Nov 8, 2025
src/main/java/org/folio/dataexp/controllers/DownloadRecordController.java
Outdated
Show resolved
Hide resolved
khandramai
approved these changes
Nov 8, 2025
…e more things to constants and utils
Contributor
Author
|
@khandramai After checking in a dev environment, I found the intermediate file from |
pkjacob
reviewed
Nov 10, 2025
pkjacob
approved these changes
Nov 10, 2025
khandramai
approved these changes
Nov 20, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
https://folio-org.atlassian.net/browse/MDEXP-884
Support a better user experience by making sure the file suffix is set consistently from the start.
Approach
Base the output file suffix on the mapping profile output format, set when the job execution's filename is first created.
Remove strategy-based suffix setting and instead read the suffix from each actual file, using it in the S3 path or the zip file internal path.
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
Does this PR meet or exceed the expected quality standards?
Does this introduce breaking changes?
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.