MODINV-542 - Optimistic locking: mod-inventory modifications for quick-marc flow#404
Merged
Conversation
RuslanLavrov
force-pushed
the
MODINV-542
branch
5 times, most recently
from
36a7ee6 to
609aca2
Compare
natali-zaitseva
force-pushed
the
MODINV-542
branch
from
f958368 to
4138c95
Compare
natali-zaitseva
requested review from
Aliaksandr-Fedasiuk,
Igor-Gorchakov,
KaterynaSenchenko,
Shans-Kaluhin,
VRohach,
julianladisch and
psmagin
psmagin
approved these changes
Oct 22, 2021
|
Kudos, SonarCloud Quality Gate passed! |
oleksandr-dekin
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In the scope of the Optimistic locking feature, mod-inventory needs to have '_version' property to be able to correctly update Inventory Instance/Holdings. For this purpose, the value 'relatedRecordVersion' which came from mod-quick-marc should be re-mapped to the corresponding '_version' property.
Approach
added re-mapping of 'relatedRecordVersion' to '_version'
explicitly set '_version' to Instance/Holdings
updated tests