MODKBEKBJ-740: Update GET /eholdings/resources/ {resourceId} to include proxiedUrl#458
Merged
shorasul96 merged 5 commits intomasterfrom May 3, 2023
Merged
MODKBEKBJ-740: Update GET /eholdings/resources/ {resourceId} to include proxiedUrl#458shorasul96 merged 5 commits intomasterfrom
shorasul96 merged 5 commits intomasterfrom
Conversation
shorasul96
requested review from
ArtHov,
Shans-Kaluhin,
pawelmol,
psmagin,
viacheslavkol and
vijay-eis
Contributor
viacheslavkol
left a comment
viacheslavkol
left a comment
There was a problem hiding this comment.
We need to increase interface version(minor) on schema extension.
I don't see any assertions for new field. Or adding for builders is enough and whole body is asserted?
psmagin
approved these changes
May 2, 2023
|
Kudos, SonarCloud Quality Gate passed! |
viacheslavkol
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implementation of changes on Proxy class proxiedUrl by holding-iq component.
Approach
Added new raml json for generating required class by ProxyUrl
Changed ProxyConverter by new class and fixed soem tests
Changes checklist