Conversation
|
in order to avoid merge conflicts README file will be updated after this PR is merged #33 (review) |
| $ref: '#/components/responses/internalServerErrorResponse' | ||
|
|
||
| /resource/metadata/{inventoryId}/id: | ||
| /linked-data/inventory-instance/{inventoryId}/resource-id: |
There was a problem hiding this comment.
It shouldn't be limited to instance resource type, there are Authority types with inventoryId also.
We have renamed InstanceMetadata class to FolioMetadata because of that.
So why don't we use just /linked-data/resource/metadata/{inventoryId}/id?
There was a problem hiding this comment.
Yes. Let us make the change as Pavel proposed.
| { | ||
| "methods": [ "POST" ], | ||
| "pathPattern": "/resource", | ||
| "pathPattern": "/linked-data/resource", |
There was a problem hiding this comment.
Let us rename the "id" in line 6 to "linked-data".
Also, remove the providers with id "profile", "reindex" and "graph" and move everything under "linked-data" provider.
|
@askhat-abishev, Let us update README file also after #33 is merged. |
sure @pkjacob I've already mentioned it in the comment to this PR |
askhat-abishev
force-pushed
the
MODLD-585
branch
from
0b79cd3 to
563eac5
Compare
askhat-abishev
force-pushed
the
MODLD-585
branch
from
563eac5 to
6f8d117
Compare
|
| @RestController | ||
| @RequiredArgsConstructor | ||
| public class AuthorityAssignmentController implements LinkedDataApi { | ||
| public class AuthorityAssignmentController implements AuthorityApi { |
There was a problem hiding this comment.
@pkjacob @PBobylev @AndreiBordak I've added this change after rebase
please let me know if you are ok with it
4 participants
No description provided.