Skip to content

MODLD-582: LCCN Validation | Ensure uniquely assigned#48

Merged
AndreiBordak merged 3 commits intomasterfrom
MODLD-582
Nov 26, 2024
Merged

MODLD-582: LCCN Validation | Ensure uniquely assigned#48
AndreiBordak merged 3 commits intomasterfrom
MODLD-582

Conversation

@AndreiBordak
Copy link
Contributor

@AndreiBordak AndreiBordak commented Nov 20, 2024

No description provided.

@AndreiBordak AndreiBordak self-assigned this Nov 20, 2024
@pkjacob
Copy link
Contributor

pkjacob commented Nov 20, 2024 •
edited
Loading

Hi @AndreiBordak,
Let us make following 2 changes in the Module descriptor.

  1. Add search.instances.collection.get permission to the modulePermissions of POST /resource and PUT /resource/id API. (As GET /search/instance API is protected by this permission. See here )
  2. Add following to the "requires" array of module descriptor
    {
      "id": "search",
      "version": "1.3"
    }

@pkjacob
Copy link
Contributor

pkjacob commented Nov 20, 2024

Hi @AndreiBordak,
There are some sonar violations. Please take a look

PBobylev
PBobylev requested changes Nov 21, 2024
View reviewed changes
@PBobylev
Copy link
Contributor

PBobylev commented Nov 22, 2024

There are 4 New issues according to SQ report above. Let's fix'em at once please?

@AndreiBordak
Copy link
Contributor Author

AndreiBordak commented Nov 22, 2024

4 New issues

fixed all except:
image

askhat-abishev
askhat-abishev approved these changes Nov 25, 2024
View reviewed changes
@PBobylev
Copy link
Contributor

PBobylev commented Nov 25, 2024

4 New issues

fixed all except: image

Let's ignore it via SuppressWarnings too, it's definitely a false-positive

@AndreiBordak
MODLD-582: LCCN Validation | Ensure uniquely assigned
6c79fbc 
MODLD-582: Change lccn value in test

MODLD-582: Additional verification for searchClient invocation

MODLD-582: Review/Sonar fixes

MODLD-582: Review/Sonar fixes

MODLD-582: Handle failed dependency

MODLD-582: Review/Sonar fixes

MODLD-582: Review/Sonar fixes

MODLD-582: Rework exception handling in search service

MODLD-582 Review fixes

MODLD-582 Review fixes

MODLD-582: Fix sonar/review

MODLD-582: Fix sonar/review
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@AndreiBordak AndreiBordak merged commit f1ed744 into master Nov 26, 2024
@pkjacob pkjacob deleted the MODLD-582 branch January 10, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkjacob pkjacob pkjacob approved these changes

@PBobylev PBobylev PBobylev approved these changes

+1 more reviewer

@askhat-abishev askhat-abishev askhat-abishev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AndreiBordak AndreiBordak

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AndreiBordak @pkjacob @PBobylev @askhat-abishev