MODLD-503: Reindex LD instance if Suppress Flags changed#5
Merged
AndreiBordak merged 1 commit intomasterfrom Oct 22, 2024
Merged
MODLD-503: Reindex LD instance if Suppress Flags changed#5AndreiBordak merged 1 commit intomasterfrom
AndreiBordak merged 1 commit intomasterfrom
Conversation
INFO: api-schema-lint: Using api-schema-lint version: 1.0.5 INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/) INFO: api-schema-lint: Found 84 JSON schema files under directory 'src/main/resources/swagger.api' ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/inventory/instanceIngressEvent.json: Missing "description" for: InstanceIngressEventMetadata ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/inventory/inventoryInstance.json: Missing "description" for: discoverySuppress, staffSuppress ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/inventory/inventoryInstanceEvent.json: Missing "description" for: new, old, tenant, type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataContributor.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataIdentifier.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataInstanceOnly.json: Missing "description" for: fromDiscovery, staff ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataTitle.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/linkedDataInstance.json: Missing "description" for: parentWork ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/srs/sourceRecordDomainEvent.json: Missing "description" for: eventMetadata, eventPayload ERROR: api-schema-lint: src/main/resources/swagger.api/schema/graphDto/resourceEdgeDto.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/graphDto/resourceEdgeDto.json: Missing "description" for: edges ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/common/Note.json: Missing "description" for: type, value ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/request/title/TitleFieldRequest.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/response/FolioMetadata.json: Missing "description" for: inventoryId, source, srsId ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/response/title/TitleFieldResponse.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceMarcViewDto.json: Missing "description" for: parsedRecord ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceRequestDto.json: Missing "description" for: Instance, Work, resource ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceResponseDto.json: Missing "description" for: Instance, Work, resource ERROR: api-schema-lint: There were processing errors. See list above. Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport. |
askhat-abishev
approved these changes
Oct 17, 2024
PBobylev
reviewed
Oct 17, 2024
src/main/resources/swagger.api/folio-modules/inventory/inventoryInstance.json
Show resolved
Hide resolved
AndreiBordak
force-pushed
the
MODLD-503
branch
2 times, most recently
from
af419d9 to
4035ba8
Compare
INFO: api-schema-lint: Using api-schema-lint version: 1.0.5 INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/) INFO: api-schema-lint: Found 84 JSON schema files under directory 'src/main/resources/swagger.api' ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/inventory/instanceIngressEvent.json: Missing "description" for: InstanceIngressEventMetadata ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/inventory/inventoryInstanceEvent.json: Missing "description" for: new, old, tenant, ts, type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataContributor.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataIdentifier.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataInstanceOnly.json: Missing "description" for: fromDiscovery, staff ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataTitle.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/linkedDataInstance.json: Missing "description" for: parentWork ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/srs/sourceRecordDomainEvent.json: Missing "description" for: eventMetadata, eventPayload ERROR: api-schema-lint: src/main/resources/swagger.api/schema/graphDto/resourceEdgeDto.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/graphDto/resourceEdgeDto.json: Missing "description" for: edges ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/common/Note.json: Missing "description" for: type, value ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/request/title/TitleFieldRequest.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/response/FolioMetadata.json: Missing "description" for: inventoryId, source, srsId ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/response/title/TitleFieldResponse.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceMarcViewDto.json: Missing "description" for: parsedRecord ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceRequestDto.json: Missing "description" for: Instance, Work, resource ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceResponseDto.json: Missing "description" for: Instance, Work, resource ERROR: api-schema-lint: There were processing errors. See list above. Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport. |
pkjacob
reviewed
Oct 21, 2024
.../org/folio/linked/data/integration/kafka/listener/handler/InventoryInstanceEventHandler.java
Outdated
Show resolved
Hide resolved
pkjacob
reviewed
Oct 21, 2024
src/main/java/org/folio/linked/data/configuration/kafka/KafkaProducerConfiguration.java
Outdated
Show resolved
Hide resolved
pkjacob
reviewed
Oct 21, 2024
src/main/java/org/folio/linked/data/configuration/kafka/LinkedDataTopicProperties.java
Outdated
Show resolved
Hide resolved
pkjacob
reviewed
Oct 21, 2024
.../org/folio/linked/data/integration/kafka/listener/handler/InventoryInstanceEventHandler.java
Outdated
Show resolved
Hide resolved
pkjacob
approved these changes
Oct 22, 2024
INFO: api-schema-lint: Using api-schema-lint version: 1.0.5 INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/) INFO: api-schema-lint: Found 84 JSON schema files under directory 'src/main/resources/swagger.api' ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/inventory/instanceIngressEvent.json: Missing "description" for: InstanceIngressEventMetadata ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataContributor.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataIdentifier.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataInstanceOnly.json: Missing "description" for: fromDiscovery, staff ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataTitle.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/linkedDataInstance.json: Missing "description" for: parentWork ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/srs/sourceRecordDomainEvent.json: Missing "description" for: eventMetadata, eventPayload ERROR: api-schema-lint: src/main/resources/swagger.api/schema/graphDto/resourceEdgeDto.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/graphDto/resourceEdgeDto.json: Missing "description" for: edges ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/common/Note.json: Missing "description" for: type, value ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/request/title/TitleFieldRequest.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/response/FolioMetadata.json: Missing "description" for: inventoryId, source, srsId ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/response/title/TitleFieldResponse.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceMarcViewDto.json: Missing "description" for: parsedRecord ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceRequestDto.json: Missing "description" for: Instance, Work, resource ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceResponseDto.json: Missing "description" for: Instance, Work, resource ERROR: api-schema-lint: There were processing errors. See list above. Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport. |
2 similar comments
INFO: api-schema-lint: Using api-schema-lint version: 1.0.5 INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/) INFO: api-schema-lint: Found 84 JSON schema files under directory 'src/main/resources/swagger.api' ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/inventory/instanceIngressEvent.json: Missing "description" for: InstanceIngressEventMetadata ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataContributor.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataIdentifier.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataInstanceOnly.json: Missing "description" for: fromDiscovery, staff ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataTitle.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/linkedDataInstance.json: Missing "description" for: parentWork ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/srs/sourceRecordDomainEvent.json: Missing "description" for: eventMetadata, eventPayload ERROR: api-schema-lint: src/main/resources/swagger.api/schema/graphDto/resourceEdgeDto.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/graphDto/resourceEdgeDto.json: Missing "description" for: edges ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/common/Note.json: Missing "description" for: type, value ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/request/title/TitleFieldRequest.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/response/FolioMetadata.json: Missing "description" for: inventoryId, source, srsId ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/response/title/TitleFieldResponse.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceMarcViewDto.json: Missing "description" for: parsedRecord ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceRequestDto.json: Missing "description" for: Instance, Work, resource ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceResponseDto.json: Missing "description" for: Instance, Work, resource ERROR: api-schema-lint: There were processing errors. See list above. Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport. |
INFO: api-schema-lint: Using api-schema-lint version: 1.0.5 INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/) INFO: api-schema-lint: Found 84 JSON schema files under directory 'src/main/resources/swagger.api' ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/inventory/instanceIngressEvent.json: Missing "description" for: InstanceIngressEventMetadata ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataContributor.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataIdentifier.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataInstanceOnly.json: Missing "description" for: fromDiscovery, staff ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/common/linkedDataTitle.json: Missing "description" for: type ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/search/linkedDataInstance.json: Missing "description" for: parentWork ERROR: api-schema-lint: src/main/resources/swagger.api/folio-modules/srs/sourceRecordDomainEvent.json: Missing "description" for: eventMetadata, eventPayload ERROR: api-schema-lint: src/main/resources/swagger.api/schema/graphDto/resourceEdgeDto.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/graphDto/resourceEdgeDto.json: Missing "description" for: edges ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/common/Note.json: Missing "description" for: type, value ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/request/title/TitleFieldRequest.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/response/FolioMetadata.json: Missing "description" for: inventoryId, source, srsId ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resource/response/title/TitleFieldResponse.json: Missing top-level "description". ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceMarcViewDto.json: Missing "description" for: parsedRecord ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceRequestDto.json: Missing "description" for: Instance, Work, resource ERROR: api-schema-lint: src/main/resources/swagger.api/schema/resourceResponseDto.json: Missing "description" for: Instance, Work, resource ERROR: api-schema-lint: There were processing errors. See list above. Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport. |
MODLD-503: Review fixes MODLD-503: Review fixes MODLD-503: Add tenant id to InventoryIndex MODLD-503: Changed reindex message format MODLD-503: Changed reindex event resource name MODLD-503: Add inventory.instance topic MODLD-503: Added IT InventoryInstanceHandler integration test MODLD-503: Reworked solution MODLD-503: Remove redundant method in FolioMetadataRepository MODLD-503: Fix Quality Gate issues
AndreiBordak
force-pushed
the
MODLD-503
branch
from
4f9acb9 to
d7ce3b7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.