MODLD-586: LCCN Normalization | Auto-add white spaces

[askhat-abishev]

No description provided.

[pkjacob]

Do we need to overcomplicate this by adding <T>? LCCN is always going to be a string. So, instead of T, we can hardcode the type as String right? Or do you foresee any need to support other datatypes for LCCN in future?

[askhat-abishev]

Yes, I thought that in future we can normalize something other than just String. It should have been called just Normalizer but I forgot to rename it properly.

[pkjacob]

Hi @askhat-abishev,
Although this code will work, I think we can improve it. Currently, we first apply the StructureA normalizer and then pass the output to the StructureB normalizer (or vice versa). While this approach might work in this case, it isn’t logically correct. We should apply only one of the normalizers, determined by the pattern of the incoming LCCN.

So, I think a more clean structure for LccnNormalizer is as follows

public interface LccnNormalizer extends Predicate<String>, UnaryOperator<String> {
  // Return normalized LCCN value if it is valid, otherwise return empty Optional
  default Optional<String> normalize(String t) {
    if (this.test(t)) { // In `test` method, check if LCCN's pattern match corresponding regex
      return Optional.of(this.apply(t)); // Do actual normalization in `apply` method.
    }
    return Optional.empty();
  }
}

Then apply the normalization in LccnPatternValidator as follows

  private String normalize(String lccn) {
    return lccnNormalizers
      .stream()
      .flatMap(normalizer -> normalizer.normalize(lccn).stream())
      .findFirst()
      .orElse(lccn);
  }

What do you think?

[askhat-abishev]

done

[pkjacob]

minor - AbstractLccnNormalizer is a better name I think.
Similarly, LccnNormalizerStructrueA and LccnNormalizerStructrueB

[askhat-abishev]

done

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud