Conversation
pkjacob
reviewed
Dec 31, 2024
| coreMapper.addOutgoingEdges(instance, InstanceRequest.class, instanceDto.getCarrier(), CARRIER); | ||
| coreMapper.addOutgoingEdges(instance, InstanceRequest.class, instanceDto.getCopyright(), COPYRIGHT); | ||
| coreMapper.addOutgoingEdges(instance, InstanceRequest.class, instanceDto.getWorkReference(), INSTANTIATES); | ||
| coreMapper.addOutgoingEdges(instance, InstanceRequest.class, instanceDto.getIllustrations(), ILLUSTRATIONS); |
Contributor
There was a problem hiding this comment.
Illustrations is an outgoing edge of Work.
So, this change should be made in WorkMapperUnit.
Similarly, Changes made in "InstanceRequest.json" and "InstanceResponse.json" has to be moved to "WorkRequest.json" and "WorkResponse.json"
pkjacob
requested changes
Dec 31, 2024
Contributor
pkjacob
left a comment
pkjacob
left a comment
There was a problem hiding this comment.
Illustrations is an outgoing edge of Work.
So, change should be made in WorkMapperUnit.
Similarly, Changes made in "InstanceRequest.json" and "InstanceResponse.json" has to be moved to "WorkRequest.json" and "WorkResponse.json"
pkjacob
approved these changes
Jan 3, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.