[MODORDERS-1443]. Abandoned holding is not deleted after changing instance connection if related piece exists

[BKadirkhodjaev]

Purpose

• https://folio-org.atlassian.net/browse/MODORDERS-1443

Approach

• Add Piece retrieval and their exclusion from inside of HoldingDeletionService::getHoldingLinkedData
• Update tests

Snapshot PoLines and Pieces are correctly excluded, allowing the old holding to be deleted

12:38:18:89 [419395/orders] [diku] [bbaf4f7e-6de9-48ac-b28a-20e315ff7658] [mod_orders] INFO  HoldingDeletionService getHoldingLinkedData:: Exclusion config mode=PO_LINE_CHANGE_INSTANCE
12:38:18:89 [419395/orders] [diku] [bbaf4f7e-6de9-48ac-b28a-20e315ff7658] [mod_orders] INFO  HoldingDeletionService getHoldingLinkedData:: Searching for linked poLines and pieces in tenant=diku by holding id=40ba26b4-8524-4a0c-9616-94fb3175474f
12:38:19:11 [419395/orders] [diku] [bbaf4f7e-6de9-48ac-b28a-20e315ff7658] [mod_orders] INFO  HoldingDeletionService excludePoLines:: PoLines before exclusion=[e8677a66-2722-4541-b167-0f38fceb9040], ids to exclude=[e8677a66-2722-4541-b167-0f38fceb9040], final poLines=[]
12:38:19:11 [419395/orders] [diku] [bbaf4f7e-6de9-48ac-b28a-20e315ff7658] [mod_orders] INFO  HoldingDeletionService excludePieces:: Pieces before exclusion=[7b34eb55-45e1-4a4d-b8dd-215e04f40508], ids to exclude=[7b34eb55-45e1-4a4d-b8dd-215e04f40508], final pieces=[]
12:38:19:11 [419395/orders] [diku] [bbaf4f7e-6de9-48ac-b28a-20e315ff7658] [mod_orders] INFO  HoldingDeletionService excludeItems:: Items before exclusion=[], ids to exclude=[e5364e09-2d26-4654-baa5-ad8d1c471212], final items=[]
12:38:19:12 [419395/orders] [diku] [bbaf4f7e-6de9-48ac-b28a-20e315ff7658] [mod_orders] INFO  HoldingDeletionService getUpdatePossibleForHolding:: holdingId=40ba26b4-8524-4a0c-9616-94fb3175474f, linkedPoLines=0, linkedPieces=0, linkedItems=0, isDeletable=true
12:38:19:12 [419395/orders] [diku] [bbaf4f7e-6de9-48ac-b28a-20e315ff7658] [mod_orders] INFO  HoldingDeletionService deleteHoldingIfPossible:: isDeletable=true, holdingId=40ba26b4-8524-4a0c-9616-94fb3175474f
12:38:19:22 [419395/orders] [diku] [bbaf4f7e-6de9-48ac-b28a-20e315ff7658] [mod_orders] INFO  OrderLinePatchOperationService updateInstanceForEresource:: Updating instance for eresource type with poLineId: 'e8677a66-2722-4541-b167-0f38fceb9040'
12:38:19:65 [419395/orders] [diku] [bbaf4f7e-6de9-48ac-b28a-20e315ff7658] [mod_orders] INFO  OrderLinePatchOperationService patch:: Successfully patched operation: Replace Instance Ref for poLineId: e8677a66-2722-4541-b167-0f38fceb9040

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud