Skip to content

Revert "STUTL-33: escapeCqlValue for " \ ^ * ?"#74

Merged
zburke merged 1 commit into
masterfrom
revert-69-STUTL-33-maskCqlValue
Jul 24, 2023
Merged

Revert "STUTL-33: escapeCqlValue for " \ ^ * ?"#74
zburke merged 1 commit into
masterfrom
revert-69-STUTL-33-maskCqlValue

Conversation

@zburke
Copy link
Copy Markdown
Member

@zburke zburke commented Jul 24, 2023

Reverts #69

This appears to be a likely cause of > 150 e2e test failures when tests rely on an asterisk as part of a wildcard search. We may eventually decide to keep this work, alongside a function that permits the asterisk, as outlined in STUTL-37 / #73, but we'll want to rearrange the order of operations (implement that function, then convert existing search code to use that function, and only then implement the breaking change outlined in STUTL-33).

FYI: @julianladisch

@github-actions
Copy link
Copy Markdown

Jest Unit Test Statistics

42 tests   - 1   42 ✔️  - 1   2s ⏱️ ±0s
  8 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 39375c3. ± Comparison against base commit 2a77364.

This pull request removes 4 and adds 3 tests. Note that renamed tests count towards both.
escapeCqlValue masks all five CQL special characters escapeCqlValue("") should be "" ‑ escapeCqlValue masks all five CQL special characters escapeCqlValue("") should be ""
escapeCqlValue masks all five CQL special characters escapeCqlValue("?*^\\\"??**^^\\\\\"\"") should be "\\?\\*\\^\\\\\\\"\\?\\?\\*\\*\\^\\^\\\\\\\\\\\"\\\"" ‑ escapeCqlValue masks all five CQL special characters escapeCqlValue("?*^\\\"??**^^\\\\\"\"") should be "\\?\\*\\^\\\\\\\"\\?\\?\\*\\*\\^\\^\\\\\\\\\\\"\\\""
escapeCqlValue masks all five CQL special characters escapeCqlValue("f\"o\\o^b*a?r") should be "f\\\"o\\\\o\\^b\\*a\\?r" ‑ escapeCqlValue masks all five CQL special characters escapeCqlValue("f\"o\\o^b*a?r") should be "f\\\"o\\\\o\\^b\\*a\\?r"
escapeCqlValue masks all five CQL special characters escapeCqlValue("foo_bar baz%") should be "foo_bar baz%" ‑ escapeCqlValue masks all five CQL special characters escapeCqlValue("foo_bar baz%") should be "foo_bar baz%"
correctly escapes CQL special characters does not modify non-special strings ‑ correctly escapes CQL special characters does not modify non-special strings
correctly escapes CQL special characters escapes backslash (\) with a backslash ‑ correctly escapes CQL special characters escapes backslash (\) with a backslash
correctly escapes CQL special characters escapes quote (") with a backslash ‑ correctly escapes CQL special characters escapes quote (") with a backslash

@github-actions
Copy link
Copy Markdown

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 39375c3. ± Comparison against base commit 2a77364.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant