Merged
Conversation
…space and enter, otherwise tab is broken
…ose button styling to use default Icon instead
…ve and use Primary as default, adapt most button elements to use Button component instead
…o button-standard and propagate
…s and not just the main editor, remove React styled component and use SCSS instead to avoid inconsistency between global colors, etc.
… component to utilize common styling
…es up, by adding a focus fallback to the modal container itself
…itch simple field from hover to focus style
SKarolFolio
approved these changes
Apr 3, 2026
pkjacob
approved these changes
Apr 5, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/UILD-761
Align styling more closely to Stripes. In addition to aligning styling to Stripes:
selectButtonType.Passive, never used directly and only as the default, changing most instances that didn't define a type toButtonType.Icon.ButtonType.Primaryis now the default, though all Buttons are now using a definedtypeButtoninstead of nativebuttonalmost everywhereSelectinstead of nativeselectinModalChooseProfileDropdownunintentionally traps focus and doesn't allow tabbing to any other elementI noticed that src/components/DeleteRecord/DeleteRecord.tsx is currently not referenced from anything, and I was not clear on whether src/views/Search/data/filters.ts or src/features/complexLookup/configs/complexLookupFilters.config.ts were somehow indirectly referenced either.