Feature/UI v2#4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b614c9ad07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [tool.setuptools] | ||
| include-package-data = true | ||
|
|
||
| [tool.setuptools.package-data] | ||
| flowk = ["ui/v2/dist/**/*", "ui/v2/dist/*"] |
There was a problem hiding this comment.
ui/v2/dist
These package-data entries only work if flowk/ui/v2/dist already exists, but that directory is ignored by flowk/ui/v2/.gitignore and is not present in this commit (git ls-tree only shows src/, public/, and index.html). I checked .github/workflows/publish.yml:16-21, and the release job still does only python -m build—there is no npm run build step to create dist first—so the published wheel/sdist will still omit the UI bundle. On a normal PyPI install, create_app() therefore won't find ui_dist, so this change doesn't actually fix shipping the / UI.
Useful? React with 👍 / 👎.
1 participant
No description provided.