fix(cli): route focus() to session for external tmux sessions#303
Open
arbrandes wants to merge 1 commit intofolke:mainfrom
Open
fix(cli): route focus() to session for external tmux sessions#303arbrandes wants to merge 1 commit intofolke:mainfrom
arbrandes wants to merge 1 commit intofolke:mainfrom
Conversation
`require("sidekick.cli").focus()` short-circuited on `not state.terminal`,
so external tmux sessions (created with `mux.create = "split"` or
`"window"`) never received focus when the keymap fired. Call
`session:focus()` in that branch so the sidekick pane is selected via
`tmux select-pane`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #198 made external tmux panes receive focus when attaching via
select/show/send, but the dedicated focus keymap (require("sidekick.cli").focus(), commonly bound to<C-.>) still didn't work for external tmux sessions.This change adds an external-session branch at the top of the
M.focuscallback that callssession:focus()directly, so pressing the focus keymap on an attached external tmux session runstmux select-paneon the sidekick pane as expected.