Skip to content

Fix boolean operation with Full element and single intersection #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fontanf merged 1 commit into from
Apr 28, 2026
Merged

Fix boolean operation with Full element and single intersection #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/boolean_operations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,19 @@ ComputeSplittedElementsOutput compute_splitted_elements(
<< " component_id " << component_id
<< std::endl;
#endif

// A Full circle with exactly one intersection point cannot be split into
// two arcs. Add the antipodal point as a fake second split point so the
// existing splitting logic produces two proper anticlockwise arcs.
if (element.type == ShapeElementType::CircularArc
&& element.orientation == ShapeElementOrientation::Full
&& elements_intersections[element_pos].size() == 1) {
const Point& p = elements_intersections[element_pos].front();
elements_intersections[element_pos].push_back({
2 * element.center.x - p.x,
2 * element.center.y - p.y});
}

// Sort intersection points of this element.
std::sort(
elements_intersections[element_pos].begin(),
Expand Down
Loading