Add support for variable COLR tables using VarIndexBase and DeltaSetIndexMap#88
Conversation
|
oops, clicked the green button too soon 😅 |
|
Thanks for getting this started! Much apreciated. |
…ndexMap Towards fontra#53 Requies the https://github.com/fonttools/fonttools/compare/wip-variable-colr?expand=1 branch of fonttools to work
the offset (from VarIndexBase + {offset}) is implicit in the ordering of the variable attributes, thus we use enumerate to construct the dict.
f90e34b to
cad2945
Compare
|
I suppose this PR needs tests to be added. I am not familiar with the test suite. Mind leaving that to you? I'll be on leave for a couple weeks from tomorrow. |
|
Thanks! Are there any Variable COLRv1 test fonts around? |
Absolutely. Thank you so much for the implementation! |
|
if you want a really simple one you can cd in fontTools/Tests/varLib/data and run |
…add var location to output filename
|
I added the fonttools test font + glyphs to the test suite. Can you briefly verify that the images in the expected output are as you expect them to be? |
yes, they look correct, thanks! |
justvanrossum
left a comment
There was a problem hiding this comment.
Fantastic! More test cases would be nice, but let's do that later.
Towards #53
Requires the
https://github.com/fonttools/fonttools/compare/wip-variable-colr?expand=1branch of fonttools to workEDIT: the branch is now called https://github.com/fonttools/fonttools/compare/variable-colr?expand=1 (without the "wip-")