fix base_has_width and add test#5008
Merged
felipesanches merged 2 commits intofonttools:mainfrom Mar 19, 2025
Merged
Conversation
Contributor
Author
|
@felipesanches What additional is needed to have this reviewed? |
Collaborator
|
I'm on it! |
| ] | ||
| or 0xE000 <= codepoint <= 0xF8FF | ||
| or 0xF0000 <= codepoint <= 0xFFFFD | ||
| or 0x100000 <= codepoint <= 0x10FFFD |
Collaborator
There was a problem hiding this comment.
@simoncozens, I think this (ignoring PUA) would be a change to be ported to fontspector as well.
| if codepoint == 0 or codepoint is None: | ||
| continue | ||
|
|
||
| if advance == 0 and not gid not in mark_glyphs(font.ttFont): |
Collaborator
There was a problem hiding this comment.
yeah! This double usage of the not operator looks like a silly coding mistake, indeed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes concerns raised in #5007
Update
checks/base_has_width.pyto:and add
tests/test_checks_base_has_width.pyto verify correct behaviorChecklist
CHANGELOG.md