Valid classifications and stroke

[emmamarichal]

Description

At present, valid Classification values:
DISPLAY("Display"),
HANDWRITING("Handwriting"),
MONOSPACE("Monospace"),
SYMBOLS("Symbols");

Valid Stroke values:
SERIF("Serif"),
SLAB_SERIF("Slab Serif"),
SANS_SERIF("Sans Serif");

If a value is wrong, it blocks Sandbox server

Checklist

• update CHANGELOG.md
• wait for the tests to pass
• request a review

[felipesanches]

I think the check also needs to be registered (via .add_and_register_check) at fontspector/profile-googlefonts/src/lib.rs

[simoncozens]

Most of the checks on the validity of METADATA.pb live in googlefonts/metadata/validate.rs, and we're going down the route of having fewer checks which do more rather than lots of checks which each do little. So I would prefer to see this code incorporated in validate.rs - maybe ask your AI to do that? :-)

[emmamarichal]

@felipesanches @simoncozens
I made the modifications! I integrated it as a separated check, is it the good way to proceed, or should I add it like:

    // Check stroke and classifications values
    const VALID_CLASSIFICATIONS: &[&str] = &["Display", "Handwriting", "Monospace", "Symbols"];
    const VALID_STROKES: &[&str] = &["Serif", "Slab Serif", "Sans Serif"];

    if let Some(stroke) = msg.stroke.as_ref() {
        if !stroke.is_empty() && !VALID_STROKES.contains(&stroke.as_str()) {
            problems.push(Status::fail(
                "invalid-stroke",
                &format!(
                    "METADATA.pb stroke field contains invalid value '{}'. Valid values are: {}",
                    stroke,
                    VALID_STROKES.join(", ")
                ),
            ));
        }
    }

    for classification in &msg.classifications {
        if !VALID_CLASSIFICATIONS.contains(&classification.as_str()) {
            problems.push(Status::fail(
                "invalid-classification",
                &format!(
                    "METADATA.pb classifications field contains invalid value '{}'. Valid values are: {}",
                    classification,
                    VALID_CLASSIFICATIONS.join(", ")
                ),
            ));
        }
    }

    return_result(problems)
}