Emit XML even for names whose platform encoding is unsupported#235
Closed
brawer wants to merge 1 commit intofonttools:masterfrom
brawer:name
Closed
Emit XML even for names whose platform encoding is unsupported#235brawer wants to merge 1 commit intofonttools:masterfrom brawer:name
brawer wants to merge 1 commit intofonttools:masterfrom
brawer:name
Conversation
When dumping the Macintosh Skia font to XML, the TTX tool crashed with a Python exception. After this change, the font can be dumped fine. This was caused by a name record with platformID=1 (Macintosh) and platEncID=2 (Traditional Chinese).
Member
|
Thanks. I'm merging this. We can adjust for the exception if you agree, on a followup commit. |
Member
|
Merged manually. |
behdad
pushed a commit
that referenced
this pull request
Apr 17, 2015
This will make it impossible to process fonts with super-broken name tables. But we do not handle arbitrary broken fonts anyway, so this is arguably better than silently ignoring junk content. Resolves a review comment in #235. In the unit test, replace calls of deprecated unittest.assertEquals() by calls of unittest.assertEqual().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dumping the Macintosh Skia font to XML, the TTX tool crashed
with a Python exception. After this change, the font can be dumped
fine. This was caused by a name record with platformID=1 (Macintosh)
and platEncID=2 (Traditional Chinese).