Skip to content

Conversation

@TomDonoghue
Copy link
Member

@TomDonoghue TomDonoghue commented Mar 1, 2019

This is an update to some data object handling and settings management (non-breaking changes).

Main updates:

  • Data objects, that are all named tuples, are moved to a dedicated 'data.py' file
  • Utilities for managing info & fields are moved to a dedicated fooof/core/info.py file
  • Consolidate procedure for extracting & comparing attributes, generalizing into a 'get_info' and 'compare_info' function in fooof/utils
  • Add 'FOOOFSettings' & 'FOOOFDataInfo' data objects, update the 'get_*' functions from the FOOOF objects to use the data objets, and add 'add_*' methods for updating FOOOF objects
  • Split up and update data I/O procedures and data checking. Split up checking of data values and model regeneration, and general checker functions for loading from file or from data objects.
  • Update combine_fooofs, to use new approach, and to fix issues it had when added objects did not have power spectra stored in them.
  • Consolidate on consistency on settings ordering and use of tuples, etc

Overall, I think this is fairly straight-forward. Not totally sold on the name 'data.py' though, anyone have any other suggestions?

@TomDonoghue TomDonoghue requested review from rdgao and voytek March 4, 2019 19:46
@fooof-tools fooof-tools deleted a comment from codecov-io Mar 5, 2019
@fooof-tools fooof-tools deleted a comment from codecov-io Mar 5, 2019
@fooof-tools fooof-tools deleted a comment from codecov-io Mar 5, 2019
@fooof-tools fooof-tools deleted a comment from codecov-io Mar 5, 2019
@fooof-tools fooof-tools deleted a comment from codecov-io Mar 5, 2019
@TomDonoghue TomDonoghue requested review from rdgao and voytek and removed request for rdgao and voytek March 12, 2019 23:35
@TomDonoghue TomDonoghue added the 1.0 Should go into FOOOF 1.0 release label Mar 13, 2019
Copy link
Contributor

@voytek voytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, otherwise looks good!

@fooof-tools fooof-tools deleted a comment from codecov-io Mar 20, 2019
@TomDonoghue TomDonoghue merged commit 1a237f4 into master Mar 20, 2019
@TomDonoghue TomDonoghue deleted the set_avg branch March 20, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.0 Should go into FOOOF 1.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants