[ENH] Update & fix (re-)add data and settings #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryanhammonds
left a comment
ryanhammonds
left a comment
There was a problem hiding this comment.
Everything looks good to me here! I left a comment about reorganizing duplicate code into __init__.
TomDonoghue
added
1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responds to #178
For data, update to add control to not clearing prior results, if one doesn't want to .
For settings, update how
_ap_boundsis handled, to avoid bug on adding settings to an object that has cleared settings.Note: this makes
_ap_boundsbe handled more like_ap_guessis