Fix #107: TimezoneManager.parseTimezone() references non-existent database.abbreviations#113
Merged
thedhanawada merged 1 commit intomasterfrom Mar 20, 2026
Merged
Conversation
The parseTimezone() method referenced this.database.abbreviations, but TimezoneDatabase uses this.aliases. This caused timezone abbreviation lookups (EST, PST, CET, etc.) to silently fail. Fixes #107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Changed
this.database.abbreviationstothis.database.aliasesinparseTimezone()(TimezoneManager.js:368-372).The
TimezoneDatabaseclass stores timezone abbreviation mappings inthis.aliases, butparseTimezone()was looking forthis.database.abbreviationswhich doesn't exist. This caused all timezone abbreviation lookups (EST, PST, CET, etc.) to silently fail and fall through to the offset parser.Files Changed
core/timezone/TimezoneManager.js— 3 lines changed (property name fix)Fixes #107