Fix #108: ICSParser VALARM export uses reminder.minutesBefore#114
Merged
thedhanawada merged 1 commit intomasterfrom Mar 20, 2026
Merged
Fix #108: ICSParser VALARM export uses reminder.minutesBefore#114thedhanawada merged 1 commit intomasterfrom
thedhanawada merged 1 commit intomasterfrom
Conversation
ICSParser.eventToICS() used reminder.minutes but Event normalizes reminders to use reminder.minutesBefore. This caused all VALARM triggers to fall back to the default 15 minutes. Fixes #108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Changed
reminder.minutestoreminder.minutesBeforein ICSParser.js line 235.The Event class normalizes all reminders to use
minutesBeforeas the canonical property (Event.js:162, 704, 904), but the ICS export was readingreminder.minuteswhich is undefined after normalization. This caused all VALARM triggers to default to 15 minutes regardless of the actual reminder setting.Files Changed
core/ics/ICSParser.js— 1 line changedFixes #108