Fix #110: Remove double DST adjustment in addHoursWithDST()#116
Merged
thedhanawada merged 1 commit intomasterfrom Mar 20, 2026
Merged
Fix #110: Remove double DST adjustment in addHoursWithDST()#116thedhanawada merged 1 commit intomasterfrom
thedhanawada merged 1 commit intomasterfrom
Conversation
addHoursWithDST() added hours via UTC milliseconds (which is already DST-agnostic) then applied an additional DST offset correction. This double-adjustment caused times crossing DST boundaries to be off by the DST delta (typically 1 hour). Removed the redundant adjustment since UTC millisecond arithmetic inherently handles DST transitions correctly. Fixes #110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Removed the redundant DST offset adjustment block from
addHoursWithDST()(DateUtils.js:517-523).UTC millisecond arithmetic (
setTime()with millis) is inherently DST-agnostic — it operates on absolute time. The previous code added hours correctly via UTC millis, then applied an additional DST offset correction that shifted the result by the DST delta (typically +/- 1 hour), producing incorrect times when crossing DST boundaries.Files Changed
core/calendar/DateUtils.js— removed 10 lines, added 3 linesFixes #110