Fix #111: ReDoS vulnerability in email validation regex#117
Merged
thedhanawada merged 1 commit intomasterfrom Mar 20, 2026
Merged
Fix #111: ReDoS vulnerability in email validation regex#117thedhanawada merged 1 commit intomasterfrom
thedhanawada merged 1 commit intomasterfrom
Conversation
The regex /^[^\s@]+@[^\s@]+\.[^\s@]+$/ had overlapping character classes around the dot, causing O(n^2) backtracking on crafted input like "user@" + "a".repeat(50). Changed the middle group to [^\s@.]+ (excluding dot) to eliminate the overlap and make the regex linear-time. Fixes #111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Changed email regex from
/^[^\s@]+@[^\s@]+\.[^\s@]+$/to/^[^\s@]+@[^\s@.]+\.[^\s@]+$/in two locations (Event.js:152 and Event.js:922).The original regex had overlapping
[^\s@]+character classes on both sides of the dot literal. When input like"user@aaa...aaa"(no dot) was tested, the engine tried all possible splits between the two groups, causing O(n^2) backtracking. Adding.to the exclusion set of the middle group ([^\s@.]+) eliminates the overlap.Security
Files Changed
core/events/Event.js— 2 regex patterns updatedFixes #111