chore: remove stale artifacts and debug console.log#18
Merged
thedhanawada merged 3 commits intomasterfrom Feb 18, 2026
Merged
Conversation
Three items cleaned up: 1. console.log in src/index.js The 'Force Calendar Interface loading...' log fired in every consumer's browser on import. Library code must not produce console output in production — it pollutes consumer devtools and is a violation of the principle of least surprise. 2. rollup.config.js (deleted) This file pointed to non-existent source paths (core/index.js, demo/dist/) and referenced packages not present in devDependencies. It was vestigial from a previous monorepo layout and could not run. Keeping dead config files implies they are maintained and usable. 3. demo.html (deleted) The secondary demo page referenced the wrong dist filename (forcecal-main-interface.esm.js instead of force-calendar-interface.esm.js) and called calendar.setEvents() and calendar.clearEvents() which do not exist on the public API. The active development demo is index.html; this file was an unmaintained duplicate from an earlier API iteration.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three cleanup items with no functional impact:
1. Remove
console.logfromsrc/index.js'Force Calendar Interface loading...'was logged to the console on every import in browser environments. Library code must not produce console output — it pollutes consumer devtools and violates the principle of least surprise for any project using this package.2. Delete
rollup.config.jsThis file was vestigial from a previous monorepo structure. It referenced source paths (
core/index.js, outputdemo/dist/) that do not exist in this repository, and declared rollup plugin dependencies (@rollup/plugin-node-resolve,@rollup/plugin-terser) that are not indevDependencies. The file could not run. The active build tool is Vite (vite.config.js).Keeping dead config files signals to contributors that they are maintained and usable — they are not.
3. Delete
demo.htmlThe secondary demo page had two independent failures:
forcecal-main-interface.esm.js(correct name:force-calendar-interface.esm.js) — it would produce a 404 on loadcalendar.setEvents()andcalendar.clearEvents()which are not part of the public APIThe active development demo is
index.html(used vianpm run dev). This file was an unmaintained copy from an older API iteration.Test plan
npm run buildsucceedsconsole.logoutput when importing the library