Make EventBus.emit() synchronous to match actual usage#26
Merged
thedhanawada merged 1 commit intomasterfrom Feb 19, 2026
Merged
Make EventBus.emit() synchronous to match actual usage#26thedhanawada merged 1 commit intomasterfrom
thedhanawada merged 1 commit intomasterfrom
Conversation
emit() was declared async and returned Promise.all(), but every single call site treated it as synchronous (no await, no .then()). This caused a misleading API contract and silently swallowed async handler errors. A UI event bus has no reason to be async. Removed the async keyword, Promise collection, and Promise.all return. Handlers are now invoked synchronously with errors caught and logged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan