NEW: @W-18146548@: Add new Flow Scanner rules #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randi274
reviewed
Oct 24, 2025
stephen-carter-at-sf
force-pushed
the
sc/UpdateFlowScanner
branch
from
0fc69eb to
d49221c
Compare
| return QueryDescription( | ||
| query_id=self.query_id, | ||
| query_name=self.query_name, | ||
| query_description="This rule detects when there are CRUD flow elements within a loop (RecordLookups, RecordCreates, RecordUpdates, RecordDeletes). This rule does not trigger if the CRUD element is in a fault handler. These DB operations should be bulkified by using collections and the IN condition. This rule does not follow subflows.", |
Contributor
Author
There was a problem hiding this comment.
I manually fixed all the query_descriptions for now. Waiting on Robert to do this on his end.
Comment on lines
+137
to
+138
| // The name of the flow scanner query. Unfortunately this is what shows up in the results instead of the id. | ||
| queryName: string, |
Contributor
Author
There was a problem hiding this comment.
In the near future Robert said he'll add queryId to the results files in addition to the queryName. So soon we'll be able to remove this queryName hopefully.
Comment on lines
+140
to
+141
| // Should be true if the rule is queried by the --optional_queries flag and false if it is in the default preset | ||
| isOptional: boolean |
Contributor
Author
There was a problem hiding this comment.
Soon Robert said he'll make all queries optional in a sense (where we can pass them all in - including the ones in the default preset)... so that we don't have to play the game of marking some as optional and some as required (and omit results after the fact). For now, this is our workaround.
stephen-carter-at-sf
force-pushed
the
sc/UpdateFlowScanner
branch
from
d49221c to
5843e73
Compare
jfeingold35
reviewed
Oct 24, 2025
packages/code-analyzer-flow-engine/test/test-data/goldfiles/all_rules.goldfile.json
Show resolved
Hide resolved
packages/code-analyzer-flow-engine/test/test-data/goldfiles/all_rules.goldfile.json
Outdated
Show resolved
Hide resolved
randi274
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be for the November release and not the October release.