CHANGE (CodeAnalyzer): @W-13887486@: Make PMD7 the new default and remove PMD6 #1403
Conversation
| it('Case: --engine pmd-appexchange against unclean code', () => { | ||
| // Currently this test fails because the pmd-appexchange jar files depend on classes that only exist in PMD6 | ||
| // TODO: Turn this test back on as soon as we get the new jar files for pmd-appexchange that work with PMD7 | ||
| xit('Case: --engine pmd-appexchange against unclean code', () => { |
There was a problem hiding this comment.
Will reenable this with PR: #1411 ... but this PR needs to be merged first.
stephen-carter-at-sf
changed the title
stephen-carter-at-sf
force-pushed
the
d/W-13887486
branch
from
2d8c8f3 to
4a3a640
Compare
| "lint-typescript": "eslint ./src --ext .ts --max-warnings 0", | ||
| "test": "./gradlew test jacocoTestCoverageVerification && nyc mocha --timeout 10000 --retries 5 \"./test/**/*.test.ts\"", | ||
| "test-quiet": "cross-env SFGE_LOGGING=false ./gradlew test jacocoTestCoverageVerification && nyc mocha --timeout 10000 --retries 5 \"./test/**/*.test.ts\"", | ||
| "test": "./gradlew test jacocoTestCoverageVerification && nyc mocha --timeout 60000 --retries 5 \"./test/**/*.test.ts\"", |
There was a problem hiding this comment.
why are we making this change?
There was a problem hiding this comment.
You'll notice that test-typescript already has a --timeout of 60000 ... so I was updating the others to reflect that change in all the commands. Basically on a given users machine a few tests go over 10 seconds... on my machine 3 tests consistently take 12 to 13 seconds. In the past, Josh updated test-typescript (which is the command he uses locally) to 60 seconds. I personally use yarn test locally to just run all the tests for all subprojects. So increasing this timeout to 60 seconds is the safest thing to do... it allows us to run things locally without tests dying but gives a sanity check for a run away test to stop and fail in our build system.
| extractRules(); | ||
|
|
||
| // STEP 2: Process the category files to derive category and rule representations. | ||
| // STEP: Process the category files to derive category and rule representations. |
There was a problem hiding this comment.
Nit: Remove "STEP:" so the comments are consistent.
There was a problem hiding this comment.
ok - good catch. done.
jfeingold35
left a comment
jfeingold35
left a comment
There was a problem hiding this comment.
Looks good, basically just the one stylistic change.
There was a problem hiding this comment.
This file has some tabs-vs-spaces conflicts. If the new changes can be tabs, then it'll all be fine.
There was a problem hiding this comment.
ok - done.
stephen-carter-at-sf
force-pushed
the
d/W-13887486
branch
from
9622402 to
d5e2cc5
Compare
| <groupId>net.sourceforge.pmd</groupId> | ||
| <artifactId>pmd-apex</artifactId> |
There was a problem hiding this comment.
I just tested this locally and built it successfully. The only dependency needed is the pmd-apex v7.0.0 now.
stephen-carter-at-sf
force-pushed
the
d/W-13887486
branch
from
56eb870 to
d0a55f4
Compare
stephen-carter-at-sf
force-pushed
the
d/W-13887486
branch
from
8b8e90a to
a78d1fa
Compare
|
Fixes #1293 |
Uh oh!
There was an error while loading. Please reload this page.