Conversation
markdlv-sf
reviewed
Apr 29, 2025
|
|
||
|
|
||
| DOCKER_IMAGE_NAME = "datacloud-custom-code" | ||
| DEPENDENCIES_ARCHIVE_NAME = "dependencies.tar.gz" |
Contributor
There was a problem hiding this comment.
Note to self: this will need to be native_dependencies.tar.gz because we want any deps with .so files to function properly.
markdlv-sf
reviewed
Apr 29, 2025
| "Deployment completed, Elapsed time: {time.time() - start_time}" | ||
| ) | ||
| break | ||
| time.sleep(1) |
Contributor
There was a problem hiding this comment.
Note to self: I think we'll want to increase this to ~5, or at least 3
markdlv-sf
reviewed
Apr 29, 2025
| return access_token | ||
|
|
||
|
|
||
| def run_data_transform( |
Contributor
There was a problem hiding this comment.
Note to self, this is currently unused
markdlv-sf
reviewed
Apr 29, 2025
| "datetime64[ns]": TimestampType(), | ||
| "datetime64[ns, UTC]": TimestampType(), | ||
| "bool": BooleanType(), | ||
| } |
Contributor
There was a problem hiding this comment.
Note to self: we were never sure why/if this was truly needed (since the previous SDK never needed it).
markdlv-sf
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up and added SDK code in preparation for open sourcing.