Add eslint and update code #2
Conversation
lcampos
requested review from
AnanyaJha,
brpowell,
jag-j,
rcoringrato-sfdc and
sfsholden
| "sourceType": "module" | ||
| }, | ||
| "plugins": ["@typescript-eslint", "jsdoc"], | ||
| "extends": ["plugin:@typescript-eslint/recommended"], |
There was a problem hiding this comment.
Here's the list of the recommended rules we're extending from https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/src/configs/recommended.json
| }, | ||
| "plugins": ["@typescript-eslint", "jsdoc"], | ||
| "extends": ["plugin:@typescript-eslint/recommended"], | ||
| "rules": { |
There was a problem hiding this comment.
If you want to check specific rules you can get the docs for them on https://eslint.org/docs/rules/
src/i18n/i18n.ts
Outdated
| export const messages = { | ||
| md_request_fail: 'Metadata API request failed', | ||
| md_request_timeout: 'Metadata API request timed out' | ||
| mdRequestFail: 'Metadata API request failed', |
There was a problem hiding this comment.
Are we switching the convention from underscores to camelCasing for the messages? If it's switching can you update the other ones when you're resolving the conflicts?
There was a problem hiding this comment.
I'm thinking I'll get rid of that rule for now
| "@types/mocha": "^5", | ||
| "@types/node": "^10", | ||
| "@types/sinon": "^7.5.2", | ||
| "@types/sinon": "^7.5.2", |
There was a problem hiding this comment.
Small nitpick - formatting was off here for some reason
There was a problem hiding this comment.
Also think this has to be "^2.3.2"
Pulling changes from main
Add eslint configuration to the project.
@W-7302635@