Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
.github/workflows/ci.ymlthat restores and builds the solution across a Windows matrix of framework aliases usingnuget restoreandmsbuild, and builds SDK-style projects onubuntu-latestusingdotnet build.src/*/*.Modern(FlatFile.Core.Modern,FlatFile.Core.Attributes.Modern,FlatFile.Delimited.Modern,FlatFile.FixedLength.Modern,FlatFile.Delimited.Attributes.Modern,FlatFile.FixedLength.Attributes.Modern) targetingnetstandard2.0;net8.0and compiling the existing source files.assets/psake-common.ps1) to include additional framework aliases (NET451,NET452,NET46,NET461,NET462,NET47,NET471,NET472,NET48) to enable multi-target builds for .NET Framework consumers.docs/modernization-plan.md, updateREADME.mdwith modernization status, and add a small compatibility-related change toParseLineException(serialization constructor wrapped with#pragma warning disable/restore SYSLIB0051).Testing
nuget restore+msbuildmatrix for legacy targets anddotnet buildfor the new SDK-style projects as defined in.github/workflows/ci.yml.Codex Task