[tests] fix run.bash bugs#146
Merged
antonio-leblanc merged 2 commits intoMay 13, 2026
Merged
Conversation
Line 44 was launching tests in runff directory instead of runANN (line 44)
The if/else above (line 54-63) always exits, so ./clean.bash is never reached.
antonio-leblanc
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small bugs in
tests/run.bash:Line 44:
run_test "runANN" "runff"invoked the runff test twice and reported success under the runANN label, while the runANN directory was never tested. Fixed torun_test "runANN" "runANN".Last line:
./clean.bashwas unreachable because the preceding if/else always exits. Cleanup remains available viamake clean.Verified locally with
make -C tests test(now runs both runff and runANN).Note: this surfaces a separate pre-existing issue.
tests/runANN/result.txt.refwas deleted in commit 9431a18 (June 2025) buttests/runANN/run.bashstill expects it viadiff. To address in a follow-up PR.