Add skip link to stats and analytics pages#13487
Merged
Conversation
djuber
approved these changes
Apr 23, 2021
vaidehijoshi
approved these changes
Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR adds the skip link functionality to the analytics dashboard and the article stats pages, along with a 'main' landmark. Due to the way we transition between pages at the moment, the skip link is currently only the first focusable element on a fresh page load.
As part of #1153 we will want to change that, but it can be done as a final step once the functionality is ready on all of our pages.
Related Tickets & Documents
#1153
QA Instructions, Screenshots, Recordings
/dashboard/analyticsCleanShot.2021-04-23.at.15.33.37.mp4
UI accessibility concerns?
This adds an essential accessibility feature for keyboard users, as well as the required
mainlandmark.Added tests?
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Admin Guide, or
Storybook (for Crayons components)
or in a forem.dev post
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?