Skip to content

Add skip link to stats and analytics pages#13487

Merged
aitchiss merged 1 commit intomainfrom
aitchiss/add-skip-link-to-analytics-page
Apr 23, 2021
Merged

Add skip link to stats and analytics pages#13487
aitchiss merged 1 commit intomainfrom
aitchiss/add-skip-link-to-analytics-page

Conversation

@aitchiss
Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This PR adds the skip link functionality to the analytics dashboard and the article stats pages, along with a 'main' landmark. Due to the way we transition between pages at the moment, the skip link is currently only the first focusable element on a fresh page load.

As part of #1153 we will want to change that, but it can be done as a final step once the functionality is ready on all of our pages.

Related Tickets & Documents

#1153

QA Instructions, Screenshots, Recordings

  • Go to /dashboard/analytics
  • If you navigated there by a link click, refresh the page (as per above note on fresh page loads)
  • Press the Tab key and check the skip link appears
  • Click the skip link with either the Enter key or the mouse
  • Press Tab again and check the next focused element is the Week/Month/Infinity links
  • Go to one of your user's published articles and click the 'Stats' button
  • Refresh the page as per above note
  • Tab and check the skip link again, same as above
CleanShot.2021-04-23.at.15.33.37.mp4

UI accessibility concerns?

This adds an essential accessibility feature for keyboard users, as well as the required main landmark.

Added tests?

  • Yes
  • No, and this is why: Cypress can't yet test the Tab event properly, so for now this has to be a manual check
  • I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

nearly there

@pr-triage pr-triage Bot added the PR: draft bot applied label for PR's that are a work in progress label Apr 23, 2021
@aitchiss aitchiss marked this pull request as ready for review April 23, 2021 14:57
@pr-triage pr-triage Bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Apr 23, 2021
@aitchiss aitchiss requested review from a team, jacobherrington and vaidehijoshi and removed request for a team April 23, 2021 14:57
@aitchiss aitchiss self-assigned this Apr 23, 2021
@aitchiss aitchiss added the merge by any core This tag is a signal that you are okay with any core team member merging your code for you. label Apr 23, 2021
@pr-triage pr-triage Bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 23, 2021
@aitchiss aitchiss merged commit 2447bc3 into main Apr 23, 2021
@aitchiss aitchiss deleted the aitchiss/add-skip-link-to-analytics-page branch April 23, 2021 15:17
@pr-triage pr-triage Bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge by any core This tag is a signal that you are okay with any core team member merging your code for you. PR: merged bot applied label for PR's that are merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants