Merged
Conversation
A simply refactor to introduce more idiomatic method names. Related to #15624
Zhao-Andy
approved these changes
Dec 1, 2021
pr-triage
bot
added
PR: partially-approved
juliannatetreault
approved these changes
Dec 1, 2021
Contributor
juliannatetreault
left a comment
juliannatetreault
left a comment
There was a problem hiding this comment.
Left a quick question, but otherwise looks good!
| @@ -62,7 +62,7 @@ def unsuspend_user | |||
|
|
|||
| expect(user.suspended?).to eq(true) | |||
| expect(user.trusted).to eq(false) | |||
Contributor
There was a problem hiding this comment.
With all of these refactors, are we also planning on changing trusted to trusted?
Contributor
There was a problem hiding this comment.
maybe we already did (and it's just a change in the callers)?
https://github.com/forem/forem/blob/main/app/models/user.rb#L384
pr-triage
bot
added
PR: merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
A simply refactor to introduce more idiomatic method names.
Related Tickets & Documents
Related to #15624
QA Instructions, Screenshots, Recordings
None.
UI accessibility concerns?
None.
Added/updated tests?
[Forem core team only] How will this change be communicated?