Skip to content

Ridhwana/Remove shecoded (Please do NOT merge as yet)#6357

Merged
benhalpern merged 5 commits intoforem:masterfrom
Ridhwana:Ridhwana/remove-shecoded
Mar 2, 2020
Merged

Ridhwana/Remove shecoded (Please do NOT merge as yet)#6357
benhalpern merged 5 commits intoforem:masterfrom
Ridhwana:Ridhwana/remove-shecoded

Conversation

@Ridhwana
Copy link
Copy Markdown
Contributor

@Ridhwana Ridhwana commented Feb 28, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature (Kind of)
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Remove shecoded page from the repo.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] Are there any post deployment tasks we need to perform?

This CANNOT be merged until we have created the new SheCoded Internal Page, else we will have a missing landing page.

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@Ridhwana Ridhwana added the PR: draft bot applied label for PR's that are a work in progress label Feb 28, 2020
@Ridhwana Ridhwana requested a review from a team as a code owner February 28, 2020 15:33
@Ridhwana Ridhwana requested review from a team and lightalloy and removed request for a team February 28, 2020 15:33
@lightalloy
Copy link
Copy Markdown
Contributor

There is also an action PagesController#shecoded to be removed.
We can also remove the related line from CODEOWNERS file.

@Ridhwana
Copy link
Copy Markdown
Contributor Author

NOTE: This CANNOT be merged until we have created the new SheCoded Internal Page, else we will have a missing landing page.

Copy link
Copy Markdown
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for 🔪 code!

@Ridhwana Ridhwana changed the title Ridhwana/remove shecoded Ridhwana/Remove shecoded (Approve but please do not merge as yet) Feb 28, 2020
@Ridhwana Ridhwana removed the PR: draft bot applied label for PR's that are a work in progress label Feb 28, 2020
@Ridhwana Ridhwana requested review from joshpuetz and rhymes February 28, 2020 16:43
Copy link
Copy Markdown
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@Ridhwana Ridhwana requested review from benhalpern and removed request for joshpuetz February 28, 2020 17:34
Copy link
Copy Markdown
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@Ridhwana Ridhwana changed the title Ridhwana/Remove shecoded (Approve but please do not merge as yet) Ridhwana/Remove shecoded (Please do NOT merge as yet) Feb 28, 2020
@Ridhwana
Copy link
Copy Markdown
Contributor Author

@jessleenyc just tagging you on this PR which will need to be merged after we create the page

@benhalpern benhalpern merged commit dee8d39 into forem:master Mar 2, 2020
@pr-triage pr-triage Bot added the PR: merged bot applied label for PR's that are merged label Mar 2, 2020
@Ridhwana Ridhwana deleted the Ridhwana/remove-shecoded branch April 29, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: merged bot applied label for PR's that are merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants